Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export to file #3529

Closed
wants to merge 6 commits into from
Closed

Export to file #3529

wants to merge 6 commits into from

Conversation

omeryagmurlu
Copy link

Short Description:

Adds a worker to export some useful information, currently only csv format.

Fixes:

@Nihisil
Copy link
Contributor

Nihisil commented Aug 11, 2016

@TheSavior what do you think. Should this PR be merged to the dev, or maybe better to keep this feature as separate plugin?

@elicwhite
Copy link
Contributor

I think this is a great example of something that should be a plugin. At least to start. If we find this is very popular and wants to be a built in task, we can reconsider later.

@omeryagmurlu Feel free to follow the documentation for creating plugins. https://github.com/PokemonGoF/PokemonGo-Bot/blob/master/docs/plugins.md

@elicwhite elicwhite closed this Aug 11, 2016
@omeryagmurlu
Copy link
Author

Ok, will make this a plugin.

Is there a way for plugins to have events? I registered the event in PokemonGoBot class, which I can't do with a plugin.

@elicwhite
Copy link
Contributor

What do you need to emit that event? Is it just to write to the console?

@douglascamata Do you have any thoughts on how plugins should handle this? I imagine theoretically at least, tasks could register there events in initialize using:

self.bot.event_manager.register_event('file_exported')

@douglascamata
Copy link
Member

This task and this plugin aren't really necessary. One can enable websocket and remote control and create a simple script that dumps the necessary data every now and then.

@omeryagmurlu omeryagmurlu deleted the dev branch August 11, 2016 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants