Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Debian python-protobuf dependency #3600

Closed
wants to merge 1 commit into from
Closed

remove Debian python-protobuf dependency #3600

wants to merge 1 commit into from

Conversation

hongxuchen
Copy link
Contributor

Short Description:

Debian python-protobuf dependency removed (install.sh/setup.sh);
docs/installation.md not synced

Fixes (provide links to github issues if you can):

- during installation of pgoapi, protobuf will automatically be a
dependency (confirmed with `pip show pgoapi`)

- Even for Ubuntu 16.04 LTS, python-protobuf version is
2.6.1-1.3, which is too old
  + confirmed with `apt-cache show python-protobuf`
  + see issue #1815
  (#1815)
@mention-bot
Copy link

@hongxuchen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @joergpatz, @simonsmh and @acaranta to be potential reviewers

@hongxuchen
Copy link
Contributor Author

The problem for the issue before was that after python-protobuf (through apt-get/apt/aptitude) was installed before, there is no way to uninstall it via sudo pip uninstall.

However problem still exists when python-protobuf was installed beforehand. Therefore the exact solution should be checking whether such a dependency is present (apt-cache policy python-protobuf and pip show protobuf) and issue a warning when the version is below 3.

@solderzzc
Copy link
Contributor

Please PR to dev branch. Thanks.

@solderzzc solderzzc closed this Aug 11, 2016
@hongxuchen
Copy link
Contributor Author

Created a new one #3610 , thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants