Improve IncubateEggs #4483
Merged
Improve IncubateEggs #4483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Now shows all eggs incubating and their type (2,5,10km) * Added interval to this task so it prints the eggs periodically * Print still works at right time even if distance walked hasn't changed
|
Oh, I need revert this since the CI build failed. |
|
@DeXtroTip Care to recreate as this was reverted |
|
I think this my mistake ? I fixed another issue caused the CI thing. Any advise ? |
|
OK, I didn't revert this one, just created a revert PR and then closed it. #4494 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
Now it shows all eggs currently incubating, ordered from the first going to hatch to the last.
Added "min_interval" setting at config file to print eggs info periodically. It will still show if an egg hatched or was incubated outside this interval.