Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iv setting to rename pokemon #4487

Merged
merged 3 commits into from
Aug 21, 2016
Merged

Add iv setting to rename pokemon #4487

merged 3 commits into from
Aug 21, 2016

Conversation

developerllazy
Copy link
Contributor

@developerllazy developerllazy commented Aug 21, 2016

Short Description:

add the function to setting the iv, only rename the pokemon if the iv is above the value according to the settings. It try to minimize the number of pokemon to be renamed.

Fixes/Resolves/Closes (please use correct syntax):

@mention-bot
Copy link

@developerllazy, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DayBr3ak, @amal and @bruno-kenji to be potential reviewers

@BreezeRo
Copy link
Contributor

Looks good, please add to the other versions of config.json and update the config document with the new variable.

@julienlavergne
Copy link
Contributor

julienlavergne commented Aug 21, 2016

That would be nice to be a bit more generic. What about cp ? attack ? defense ? stamina etc... should we add a parameter for all of them ?
Maybe the parameter could be a dictionary holding the minimum values for all of that:

"rename_above": {
    "iv": 0.8,
    "cp": 1200
}

@solderzzc
Copy link
Contributor

CI build failed

@solderzzc
Copy link
Contributor

how to trigger the CI again, seems I just fixed it

@solderzzc solderzzc closed this Aug 21, 2016
@solderzzc solderzzc reopened this Aug 21, 2016
@solderzzc solderzzc merged commit c549769 into PokemonGoF:dev Aug 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants