Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some variance in max amount of pokemon bag before releasing #4492

Merged
merged 5 commits into from
Aug 26, 2016

Conversation

Napator
Copy link
Contributor

@Napator Napator commented Aug 21, 2016

For more human behaviour.

@mention-bot
Copy link

@Napator, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Segflow, @achretien and @alvarogzp to be potential reviewers

@solderzzc
Copy link
Contributor

how to trigger the CI again, seems I just fixed it

@BriceSD
Copy link
Contributor

BriceSD commented Aug 21, 2016

Lets say min_free_slot = 0. In other words, transfer pokemons once my bag is full. It’ll take a lot of try before transferring, you’ve 5% chance to do so.
Same issue when 0 ≤ min_free_slot < 20.

Do you use every possible option ? Personally I don’t like to be forced to use one. What about adding this to the config file ?

@julienlavergne
Copy link
Contributor

Seems to me that it is going to rand a new number at every loop, so random distribution is very bad and you are going to release at your configured value or very close to it most of the time.

@solderzzc solderzzc closed this Aug 21, 2016
@solderzzc solderzzc reopened this Aug 21, 2016
@solderzzc
Copy link
Contributor

@anakin5 so what should we do? Any further suggestion?

@julienlavergne
Copy link
Contributor

Rand a number in the init and after work is done. That way, you will hold onto that number.
Also, check you always stay between 0 and inventory size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants