Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RandomAlivePause task #4672

Merged
merged 5 commits into from
Aug 24, 2016
Merged

Add RandomAlivePause task #4672

merged 5 commits into from
Aug 24, 2016

Conversation

cmezh
Copy link
Contributor

@cmezh cmezh commented Aug 24, 2016

This task keeps bot alive while it paused. Placed on the top of task list it drops execution of following tasks.
During pause it calls heartbeat and set_location for noising coordinates (of course, if noise is set in config).

Based on RandomPause task.
Inspired by (and also closes) #4583

@mention-bot
Copy link

@cmezh, thanks for your PR! By analyzing the annotation information on this pull request, we identified @mhdasding, @bruno-kenji and @RedViper9 to be potential reviewers

@J-A-B-S
Copy link

J-A-B-S commented Aug 24, 2016

So your saying that during paused time, It will move to a fort or something like that but without actually send the info to server and then when pause is over it will be at the location it was last at during the paused time?

@cmezh
Copy link
Contributor Author

cmezh commented Aug 24, 2016

@J-A-B-S Nope. During the pause bot will not execute tasks set in task list after RandomAlivePause. That's why RandomAlivePause must be placed on the top of task list.

@mhdasding
Copy link
Contributor

Exactly what i want, thought of doing it myself but thanks to you i don't have to =P 👍

@solderzzc
Copy link
Contributor

Why need alive pause ? In iPhone, if you switch app to background, still packet to server?

@cmezh
Copy link
Contributor Author

cmezh commented Aug 24, 2016

@solderzzc Not all users (and not always) switch app to background when they have a short break for coffee or talk with friends or whatever more. And, in my opinion, the more bot behaviour different, the more it's humanized.

@solderzzc
Copy link
Contributor

ok, since it's optional, we can merge for testing, thanks a lot. @cmezh

@solderzzc solderzzc merged commit e92dc23 into PokemonGoF:dev Aug 24, 2016
@cmezh
Copy link
Contributor Author

cmezh commented Aug 24, 2016

Thank you, @solderzzc :)

@cmezh cmezh deleted the alive_pause branch August 24, 2016 22:08
@mjmadsen mjmadsen mentioned this pull request Aug 25, 2016
@imetanon
Copy link

imetanon commented Aug 26, 2016

if bot was in RandomAlivePause mode, how to cancel or stop ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants