Nickname: Remove spaces from Nidorans #4739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating a new nickname, convert "Nidoran M/F" to "NidoranM/F"
|
@Gobberwart, thanks for your PR! By analyzing the annotation information on this pull request, we identified @amal, @douglascamata and @mhdasding to be potential reviewers |
Gobberwart
changed the title
Closed
|
Unit test failing during Travis checks. Investigating. |
|
Rerun CI. |
|
Travis CI is working now. Can we include this or no? |
|
I think we can. The ci was caused by other commit by me. After pushed the fix to dev and rerun the ci, this one turned good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
When generating a new nickname, remove spaces from Nidorans (convert "Nidoran M/F" into "NidoranM/F")
Fixes/Resolves/Closes (please use correct syntax):
This addresses the request in #3718. Not sure if any expansion needed.