Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed incorrect call to jsonify_inventory #4757

Merged
merged 1 commit into from
Aug 26, 2016
Merged

Removed incorrect call to jsonify_inventory #4757

merged 1 commit into from
Aug 26, 2016

Conversation

Gobberwart
Copy link
Contributor

Short Description:

Call to jsonify_inventory causes player_data to be lost from output.

Removed call to self.jsonify_inventory that results in player_stats
disappearing.
@MartinTerp
Copy link

Hi @Gobberwart , me again! can you confirm that this is working? because for me, player_stats is still not in the inventory file

@Gobberwart
Copy link
Contributor Author

@MartinTerp Working fine for me. Here's what I'm seeing in my inventory-username.json

[{"inventory_item_data": {"player_stats": {"pokemons_captured": 1561, "km_walked": 148.5740203857422, "level": 23, "big_magikarp_caught": 6, "experience": 456175, "pokemons_encountered": 1658, "pokeballs_thrown": 2709, "eggs_hatched": 46, "small_rattata_caught": 20, "unique_pokedex_entries": 80, "prev_level_xp": 335000, "evolutions": 11, "next_level_xp": 560000, "pokemon_caught_by_type": "AOgEC84DnwMbFPQBCw8M3AKAAREjAAUAHw==", "poke_stop_visits": 2908}}}

@Gobberwart
Copy link
Contributor Author

Check both top and bottom of the file... seems to vary depending on what specific tasks run where.

Also check "Info" on web interface, see what appears there.

@Gobberwart
Copy link
Contributor Author

Also note there may be a small delay updating, as the player stats only updates when UpdateLiveStats runs (to conserve api calls)

@MartinTerp
Copy link

@Gobberwart ah okay, didt think it was depended for the UpdateLiveStats, i belived that the stats was stored and calculated in the bot ( or maybe it was future plan for it ) but after enabled it, it worked :)

Thansk for your time.

@Gobberwart
Copy link
Contributor Author

@MartinTerp It's definitely in the future plan, just hasn't happened yet. There are potentially lots of different places where things will need to be found and updated, so it'll be a somewhat lengthy process to track player_stats in the bot. Working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants