Incense bugfixing #5364
Merged
Incense bugfixing #5364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added documentation and new function Solving issue PokemonGoF#5151 - part 1
If there is already an incense applied, skip the worker
|
@davidakachaos, thanks for your PR! By analyzing the annotation information on this pull request, we identified @mjmadsen, @Gobberwart and @alexyaoyang to be potential reviewers |
| self.types = { | ||
| 401: "Ordinary", | ||
| 402: "Spicy", | ||
| 403: "Cool", | ||
| 404: "Floral" | ||
| } | ||
|
|
||
|
|
||
| def _have_applied_incense(self): |
There was a problem hiding this comment.
Duplicate code from catch_pokemon.py ?
There was a problem hiding this comment.
Yes, how would I dry this up?
|
Thanks for all the feedback @sohje |
|
👍 |
|
Cant wait to try this out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
Trying my first at catching incense Pokemon. Rebased on current dev.
Fixes/Resolves/Closes (please use correct syntax):
Please review my changes and tell me if I broke something