Enhanced telegram functionality #5371
Conversation
|
@javajohnHub, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Gobberwart, @DBa2016 and @solderzzc to be potential reviewers |
|
Can we have a meaningful PR description before we start reviewing? |
|
My apologies for all the trouble with the pull request. I figured this one would fail also. |
|
The web version was touched, but I’ll get it right later |
|
👍 |
fix for issue #5358
| def __init__(self, bot, master, pokemons, config): | ||
| self.bot = bot | ||
| master = config["master"] |
There was a problem hiding this comment.
This will fail if no "master" is supplied in the config.
|
Have you tested this with "master" absent in the config file? |
|
No. if telegram class is instantiated there should always be a master. |
|
Nevermind i see what you're saying |
|
No, with the new "password" configuration, you do not need a "master" at all. |
|
So whats the solution here. This allows telegram to work for me. The other way always keeps master at None. (for me) at least |
|
If config ['master'] |
|
The master is not needed, and actually subject o be removed in future. Use password. |
|
But if you MUST use the master, always use config.get('master', None), otherwise you will get errors if master is not specified in the config. |
|
Thanks for the heads up....ill abandon this and start using password. |
| @@ -10,19 +10,23 @@ | |||
| from pokemongo_bot import inventory | |||
| from telegram.utils import request | |||
|
|
|||
| DEBUG_ON = False | |||
| DEBUG_ON = True | |||
There was a problem hiding this comment.
It should be False for publish
…unction. refactored using camelCase.
|
👍 |
Enhanced telegram functionality.
this should also close issue #5236
/softbans - shows info about possible softbans
/caught - last 25
/evolved - last 25
/hatched - last 25
/pokestops - last 25
/transfers - last 25
also displays info on events:
bot_random_pause
bot_random_alive_pause
log_stats
show_inventory