-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added release_below_ivcp and keep_best_ivcp #5465
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can tell it looks good. But I requested the feature so I might be bias.
Heh, I might wait for another review... @solderzzc @DBa2016 @alexyaoyang @mjmadsen ? |
Alright. Merging. Hope it's right :) |
Dammit, I knew there'd be an error somewhere. Looking at it. |
Hmmm line 59 isn't even a line.. |
I can't see the issue... Not even sure it's got anything to do with this PR.
|
Found it, opening PR. 👍 |
Short Description:
Added release_below_ivcp and keep_best_ivcp to TransferPokemon
Reviewers please check this very carefully as I may have missed something important
Fixes/Resolves/Closes (please use correct syntax):