Bot treats all pokemon as VIP fix

[Gobberwart]

Short Description:

Bot treats all pokemon as VIP. Additionally, default rules always return true if not configured. For example:

    "catch": {
      "any": {"catch_above_cp": 500, "catch_above_iv": 0.65, "logic": "or"}
    },

Given example pokemon with cp 30, iv 0.2 and ncp 0.15, the bot would still always catch it because no "catch_above_ncp" rule is defined. This is incorrect behaviour, should return false if no condition matches or condition doesn't exist.

Fixes/Resolves/Closes (please use correct syntax):

• Latest commit treats all pokemon it see as vip #5457
• a8ee312, All pokemon appear as VIP #5476
• catch_pokemon: catch filter does not work #5491

[mention-bot]

@Gobberwart, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DBa2016, @xc-mezcal and @pokepal to be potential reviewers

[Gobberwart]

Replaces #5479

[julienlavergne]

catch_results are initialized to False. So if the config doesn't have any rule on cp, catch_results["cp"] will be False, right ?
So with logic at and, no Pokemon will get caught, right ?

[alexyaoyang]

This is probably just a small issue, but should we introduce another debug flag here? We already have a debug flag in config now.

[Gobberwart]

this flag only applies to this rather than using global debug which generates a lot of garbage

[alexyaoyang]

Hmm ok noted

[Gobberwart]

It's not unusual. A lot of other code has the same thing. It's actually really handy when debugging a single module.

[Gobberwart]

@anakin5 That's correct as it stands... The bot really shouldn't use a rule if it's not defined in config. Let me take a look.

[Gobberwart]

@anakin5 I've added some logic to handle different default values based on catch logic. It's mucky but should account for all configurations.

Having said that, the current LOGIC_TO_FUNCTION only works if there are exactly three values. Would be much better if we could only compare what's actually set in config and ignore whatever is not set.

Leaving as-is for now so we can make the bot work properly again.

[Uldiniad]

please merge these changes to master branch. I have updated every day since these commits but still have this issue on master branch