Fixed release trigger #5499
Merged
Fixed release trigger #5499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bot randomizes min_free_slot by up to 20, so a value of 5 in config could actually be anything from 5 to -15. Bag limit never gets below zero, so bag has very large chance of filling up. Changed so will trigger if space <= 1 if random gives anything equal to or below 0.
|
@Gobberwart, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Napator, @LitRidl and @alvarogzp to be potential reviewers |
|
Very minor change, merging. |
This was referenced Sep 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
On TransferPokemon task, the bot randomizes min_free_slot by up to 20 (to simulate human-like behaviour?), so a value of 5 in config could actually be anything from 5 to -15. Bag limit never gets below zero, so bag has very large chance of filling up. Changed so will trigger if space <= 1 if random gives anything equal to or below 0.
Fixes/Resolves/Closes (please use correct syntax):