Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow use of ultraball on non-vip #5555

Merged
merged 1 commit into from
Sep 20, 2016
Merged

Allow use of ultraball on non-vip #5555

merged 1 commit into from
Sep 20, 2016

Conversation

alexyaoyang
Copy link
Contributor

@alexyaoyang alexyaoyang commented Sep 20, 2016 •
edited
Loading

Allow use of ultraball on non-vip

Fixes/Resolves/Closes (please use correct syntax):

  • Currently we use ultraballs only when both pokeball and greatball have ran out, not considering the catch rate.
  • This PR allows ultraballs to be used when

    • of ultraball > min_ultraball_to_keep AND

    • catch rate of pokemon is less than ideal threshold.

Tested for 2 days with various different accounts.

@mention-bot
Copy link

@alexyaoyang, thanks for your PR! By analyzing the annotation information on this pull request, we identified @joaodragao, @pokepal and @Quantra to be potential reviewers

Gobberwart
Gobberwart approved these changes Sep 20, 2016
View reviewed changes
Copy link
Contributor

@Gobberwart Gobberwart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Gobberwart Gobberwart merged commit 3a5c36d into PokemonGoF:dev Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gobberwart Gobberwart Gobberwart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexyaoyang @mention-bot @Gobberwart