Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telegram formatting and msg consolidation #5583

Merged
merged 2 commits into from
Sep 21, 2016
Merged

Telegram formatting and msg consolidation #5583

merged 2 commits into from
Sep 21, 2016

Conversation

javajohnHub
Copy link
Contributor

Short Description:

Telegram only sends 1 msg for a request now

Fixes/Resolves/Closes (please use correct syntax):

Telegram commands only send 1 message now instead of x many

Telegram commands only send 1 message now instead of x many
@mention-bot
Copy link

@javajohnHub, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Gobberwart to be a potential reviewer

Copy link
Contributor

@Gobberwart Gobberwart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove order_key stuff and I'll approve

if order == "cp":
order_key = 2
else: # If it's not "cp", we assume "iv"
order_key = 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used? Remove if not needed.

@Gobberwart Gobberwart merged commit 7124d15 into PokemonGoF:dev Sep 21, 2016
@andypy
Copy link

andypy commented Sep 21, 2016

got this error

Traceback (most recent call last):
File "pokecli.py", line 843, in
main()
File "pokecli.py", line 202, in main
bot.tick()
File "/PokemonGo-Bot/pokemongo_bot/init.py", line 718, in tick
if worker.work() == WorkerResult.RUNNING:
File "/PokemonGo-Bot/pokemongo_bot/cell_workers/catch_pokemon.py", line 47, in work
if self.catch_pokemon(self.pokemon.pop()) == WorkerResult.ERROR:
File "/PokemonGo-Bot/pokemongo_bot/cell_workers/catch_pokemon.py", line 159, in catch_pokemon
return_value = worker.work()
File "/PokemonGo-Bot/pokemongo_bot/cell_workers/pokemon_catch_worker.py", line 198, in work
self._do_catch(pokemon, encounter_id, catch_rate_by_ball, is_vip=is_vip)
File "/PokemonGo-Bot/pokemongo_bot/cell_workers/pokemon_catch_worker.py", line 666, in _do_catch
'daily_catch_limit': self.daily_catch_limit
File "/PokemonGo-Bot/pokemongo_bot/base_task.py", line 43, in emit_event
data=data
File "/PokemonGo-Bot/pokemongo_bot/event_manager.py", line 77, in emit
handler.handle_event(event, sender, level, formatted_msg, data)
File "/PokemonGo-Bot/pokemongo_bot/event_handlers/telegram_handler.py", line 338, in handle_event
msg = self.chat_handler.get_event(event, formatted_msg, data)
File "/PokemonGo-Bot/pokemongo_bot/event_handlers/chat_handler.py", line 46, in get_event
trigger = self.pokemons["all"]
TypeError: list indices must be integers, not str

do you have this error ? I have to revert to 92519d4 (version before git pull) to get the bot running again....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants