Fix order/display of IV and CP in Telegram /caught function #5610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JaapMoolenaar, thanks for your PR! By analyzing the annotation information on this pull request, we identified @javajohnHub, @Gobberwart and @DBa2016 to be potential reviewers |
solderzzc
approved these changes
Sep 22, 2016
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
When using the /caught function in Telegram, the CP is always 0 (or 1 in case of a perfect iv) and IV holds the CP. This PR fixes that.
It now also retrieves only the needed information from the database in a set order; something I suggest you/we do more often, seeing as you almost always select all columns. (Which might even cause these kinds of bugs in case the order of the columns changes in the table).
Fixes/Resolves/Closes:
None