Added absolute candy limit #5766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChaosMarc, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeXtroTip, @mhdasding and @solderzzc to be potential reviewers. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to
candy_limitI've added a new config parametercandy_limit_absolute. It should be used to stop collecting candy with your current buddy when a candy threshold for your buddy's pokemon family is reached (e.g. 50 for evolving).It also should fix a potential crash when your current buddy gets evolved and no other pokemon of the same type is available.