Fix hash/encrypt library searching #5804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filename is libniantichash-macos-64.dylib not libniantichash-osx-64.so
Instead of just looking in root, or encrypt_location, or whatever the heck the last person did... will first search local or encrypt_location. If not found, will search pgoapi/lib. If still not found, abort.
|
@Gobberwart, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pablossp, @seehuily and @Heihachi to be potential reviewers. |
solderzzc
approved these changes
Nov 10, 2016
|
👍 |
solderzzc
pushed a commit
that referenced
this pull request
Nov 11, 2016
* Corrected maxos niantic lib filename Filename is libniantichash-macos-64.dylib not libniantichash-osx-64.so * Better search for encrypt/hash files Instead of just looking in root, or encrypt_location, or whatever the heck the last person did... will first search local or encrypt_location. If not found, will search pgoapi/lib. If still not found, abort.
|
libniantichash-osx-64.so can't be found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description: