Feature Enhancement: Snip request through telegram #5877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MerlionRock, thanks for your PR! By analyzing the history of the files in this pull request, we identified @YvesHenri, @Gobberwart and @javajohnHub to be potential reviewers. |
Make changes to ignore Pokemon in snipe catch list for telegram mode.
To prevent looping errors due to wrong input by users, try except expression added to telegram snipe mode
solderzzc
reviewed
Jan 16, 2017
| @@ -406,12 +449,15 @@ def work(self): | |||
| else: | |||
| self.bot.sniper_disabled_global_warning = False | |||
| targets = [] | |||
| target = {} | |||
There was a problem hiding this comment.
Seems nowhere to use 'target' in the following code.
There was a problem hiding this comment.
Noted. Will delete it off. I changed this files too many times and lost track what I did.
Traget = {} removed
Added instructions on how to activate and use manual snipping through telegram
|
👍 |
solderzzc
added a commit
that referenced
this pull request
Jan 17, 2017
Feature Enhancement: Snip request through telegram (#5877)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-Created due to conflicts
Added new feature:
Snipping through telegram, enable it in config, Sniper Task "mode": "telegram"
Also fixed the problem of not able to find Pokemons without EncounterID and SpawnPointID.
Fixes#5863