Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captcha, POGOProtos and PogoAPI Check #5901

Merged
merged 1 commit into from
Feb 7, 2017
Merged

Captcha, POGOProtos and PogoAPI Check #5901

merged 1 commit into from
Feb 7, 2017

Conversation

MerlionRock
Copy link
Contributor

@MerlionRock MerlionRock commented Feb 6, 2017

Added a simple captcha check. Manual captcha solving is planned. WILL NOT add 2captcha service.

Also checking the version of POGOProtos to alert user of a possible PogoAPI changes. Can't think of a better solution as I can't find anyway to get versioning from PogoAPI.

Changes to PogoAPI check using float instead of matching against strings. In the event that PogoAPI is ahead of official Niantic API, the bot still can run.

Added a simple captcha check. Manual captcha solving is planned. WILL NOT add 2captcha service.

Also checking the version of POGOProtos to alert user of a possible PogoAPI changes. Can't think of a better solution as I can't find anyway to get versioning from PogoAPI.
@mention-bot
Copy link

@MerlionRock, thanks for your PR! By analyzing the history of the files in this pull request, we identified @douglascamata, @marksweb and @solderzzc to be potential reviewers.

@solderzzc
Copy link
Contributor

solderzzc commented Feb 7, 2017

👍

Approved with PullApprove

@solderzzc solderzzc merged commit 80668cb into PokemonGoF:dev Feb 7, 2017
@snooter
Copy link
Contributor

snooter commented Feb 8, 2017

Lack of 2Captcha is really disappointing.

@MerlionRock
Copy link
Contributor Author

@snooter The original contributors here are not keen and they don't really approve 3rd party services. Unless they change their stand, this will not change.

However, if someone else is interested, they can always code them in and submit as a PR and it is up to the reviewers to approve.

@MerlionRock MerlionRock deleted the dev branch February 8, 2017 03:15
@solderzzc
Copy link
Contributor

@MerlionRock It's welcome to have captcha service integration since it always depends on user to enable or not.

@MerlionRock
Copy link
Contributor Author

@solderzzc haha~ If you say so.

I'll find some time to look at it. I'm just treating this as a hobby. Not coding for at least 15 years, just don't want to loose a skill that I once good at. LOL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants