Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to using berries #5963

Merged
merged 5 commits into from
Mar 15, 2017
Merged

Changes to using berries #5963

merged 5 commits into from
Mar 15, 2017

Conversation

MerlionRock
Copy link
Contributor

Changes from using old API call to new API call

  • Added Pinap Berry Support TODO: New berries support #5942
  • Pinap berry will be used instead of Razz Berry if use_pinap_on_vip is set to true (Under ctach_pokemon task)
  • Razz berry will still be used when running out of Pinap Berries
  • Amount of candies gained will be reported as it is no longer fixed at 3
  • Updated documenation
  • Updated config examples

Since now candy gained is no longer fixed at 3, good to show user how many candies gained instead of just total
Changes from using old API call to new API call
Added Pinap Berry Support
- Pinap berry will be used instead of Razz Berry if use_pinap_on_vip is set to true (Under ctach_pokemon task)
- Razz berry will still be used when running out of Pinap Berries
- Amount of candies gained will be reported as it is no longer fixed at 3
Added "use_pinap_on_vip" to CatchPokemon Task. Default to false
Added instruction on how to use Pinap Berry
Wrong files uploaded perviously
@mention-bot
Copy link

@MerlionRock, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mzupan, @douglascamata and @Gobberwart to be potential reviewers.

@pogarek
Copy link
Contributor

pogarek commented Mar 15, 2017

👍

Approved with PullApprove

@pogarek
Copy link
Contributor

pogarek commented Mar 15, 2017

merged #5963

@pogarek pogarek merged commit 74058c2 into PokemonGoF:dev Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants