Improved handling of Daily Catch Limit #6142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new way to handle the daily catch limit. It will disable the catch tasks just like we ran out of balls. It will disable all catch tasks for an hour, after that it will check if the amount of catches is lower than the limit and resume catching if so. During the hour we still check if the amount of Pokemon caught is lower than the daily limit minus 20, if so the bot will resume catching again, ending the remaining wait time. Notice if we enabled "exit_on_limit_reached", the bot will still exit if the daily limit is reached!!
|
@davidakachaos, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Gobberwart and @MerlionRock to be potential reviewers. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new way to handle the daily catch limit. It will disable the
catch tasks just like we ran out of balls. It will disable all catch
tasks for an hour, after that it will check if the amount of catches is
lower than the limit and resume catching if so.
During the hour we still check if the amount of Pokemon caught is lower
than the daily limit minus 20, if so the bot will resume catching again,
ending the remaining wait time.
Notice if we enabled "exit_on_limit_reached", the bot will still exit if
the daily limit is reached!!