Skip to content

Commit

Permalink
Adds support for Hook discovery from providers
Browse files Browse the repository at this point in the history
This PR extends providers discovery with the mechanism
of retrieving mapping of connections from type to hook.

Fixes apache#12456
  • Loading branch information
potiuk committed Nov 29, 2020
1 parent 7ef9aa7 commit f7019d0
Show file tree
Hide file tree
Showing 70 changed files with 461 additions and 196 deletions.
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ repos:
entry: ./scripts/ci/pre_commit/pre_commit_check_provider_yaml_files.py
language: python
require_serial: true
files: provider.yaml$
files: provider.yaml$|scripts/ci/pre_commit/pre_commit_check_provider_yaml_files.py$
additional_dependencies: ['PyYAML==5.3.1', 'jsonschema==3.2.0', 'tabulate==0.8.7']
- id: mermaid
name: Generate mermaid images
Expand Down
6 changes: 6 additions & 0 deletions airflow/cli/cli_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -1153,6 +1153,12 @@ class GroupCommand(NamedTuple):
),
)
PROVIDERS_COMMANDS = (
ActionCommand(
name='hooks',
help='List registered provider hooks',
func=lazy_load_command('airflow.cli.commands.provider_command.hooks_list'),
args=(ARG_OUTPUT,),
),
ActionCommand(
name='list',
help='List installed providers',
Expand Down
25 changes: 22 additions & 3 deletions airflow/cli/commands/provider_command.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
"""Providers sub-commands"""
from typing import Dict, List
from typing import Dict, List, Tuple

import pygments
import yaml
Expand Down Expand Up @@ -44,8 +44,7 @@ def provider_get(args):
"""Get a provider info."""
providers = ProvidersManager().providers
if args.provider_name in providers:
provider_version = providers[args.provider_name][0]
provider_info = providers[args.provider_name][1]
provider_version, provider_info = providers[args.provider_name]
print("#")
print(f"# Provider: {args.provider_name}")
print(f"# Version: {provider_version}")
Expand All @@ -64,3 +63,23 @@ def provider_get(args):
def providers_list(args):
"""Lists all providers at the command line"""
print(_tabulate_providers(ProvidersManager().providers.values(), args.output))


def _tabulate_hooks(hook_items: Tuple[str, Tuple[str, str]], tablefmt: str):
tabulate_data = [
{
'Connection type': hook_item[0],
'Hook class': hook_item[1][0],
'Hook connection attribute name': hook_item[1][1],
}
for hook_item in hook_items
]

msg = tabulate(tabulate_data, tablefmt=tablefmt, headers='keys')
return msg


def hooks_list(args):
"""Lists all hooks at the command line"""
msg = _tabulate_hooks(ProvidersManager().hooks.items(), args.output)
print(msg)
65 changes: 3 additions & 62 deletions airflow/models/connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,70 +30,10 @@
from airflow.exceptions import AirflowException, AirflowNotFoundException
from airflow.models.base import ID_LEN, Base
from airflow.models.crypto import get_fernet
from airflow.providers_manager import ProvidersManager
from airflow.utils.log.logging_mixin import LoggingMixin
from airflow.utils.module_loading import import_string

# A map that assigns a connection type to a tuple that contains
# the path of the class and the name of the conn_id key parameter.
# PLEASE KEEP BELOW LIST IN ALPHABETICAL ORDER.
CONN_TYPE_TO_HOOK = {
"azure_batch": (
"airflow.providers.microsoft.azure.hooks.azure_batch.AzureBatchHook",
"azure_batch_conn_id",
),
"azure_cosmos": (
"airflow.providers.microsoft.azure.hooks.azure_cosmos.AzureCosmosDBHook",
"azure_cosmos_conn_id",
),
"azure_data_lake": (
"airflow.providers.microsoft.azure.hooks.azure_data_lake.AzureDataLakeHook",
"azure_data_lake_conn_id",
),
"cassandra": ("airflow.providers.apache.cassandra.hooks.cassandra.CassandraHook", "cassandra_conn_id"),
"cloudant": ("airflow.providers.cloudant.hooks.cloudant.CloudantHook", "cloudant_conn_id"),
"dataprep": ("airflow.providers.google.cloud.hooks.dataprep.GoogleDataprepHook", "dataprep_default"),
"docker": ("airflow.providers.docker.hooks.docker.DockerHook", "docker_conn_id"),
"elasticsearch": (
"airflow.providers.elasticsearch.hooks.elasticsearch.ElasticsearchHook",
"elasticsearch_conn_id",
),
"exasol": ("airflow.providers.exasol.hooks.exasol.ExasolHook", "exasol_conn_id"),
"gcpcloudsql": (
"airflow.providers.google.cloud.hooks.cloud_sql.CloudSQLDatabaseHook",
"gcp_cloudsql_conn_id",
),
"gcpssh": (
"airflow.providers.google.cloud.hooks.compute_ssh.ComputeEngineSSHHook",
"gcp_conn_id",
),
"google_cloud_platform": (
"airflow.providers.google.cloud.hooks.bigquery.BigQueryHook",
"bigquery_conn_id",
),
"grpc": ("airflow.providers.grpc.hooks.grpc.GrpcHook", "grpc_conn_id"),
"hive_cli": ("airflow.providers.apache.hive.hooks.hive.HiveCliHook", "hive_cli_conn_id"),
"hiveserver2": ("airflow.providers.apache.hive.hooks.hive.HiveServer2Hook", "hiveserver2_conn_id"),
"imap": ("airflow.providers.imap.hooks.imap.ImapHook", "imap_conn_id"),
"jdbc": ("airflow.providers.jdbc.hooks.jdbc.JdbcHook", "jdbc_conn_id"),
"jira": ("airflow.providers.jira.hooks.jira.JiraHook", "jira_conn_id"),
"kubernetes": ("airflow.providers.cncf.kubernetes.hooks.kubernetes.KubernetesHook", "kubernetes_conn_id"),
"mongo": ("airflow.providers.mongo.hooks.mongo.MongoHook", "conn_id"),
"mssql": ("airflow.providers.odbc.hooks.odbc.OdbcHook", "odbc_conn_id"),
"mysql": ("airflow.providers.mysql.hooks.mysql.MySqlHook", "mysql_conn_id"),
"odbc": ("airflow.providers.odbc.hooks.odbc.OdbcHook", "odbc_conn_id"),
"oracle": ("airflow.providers.oracle.hooks.oracle.OracleHook", "oracle_conn_id"),
"pig_cli": ("airflow.providers.apache.pig.hooks.pig.PigCliHook", "pig_cli_conn_id"),
"postgres": ("airflow.providers.postgres.hooks.postgres.PostgresHook", "postgres_conn_id"),
"presto": ("airflow.providers.presto.hooks.presto.PrestoHook", "presto_conn_id"),
"redis": ("airflow.providers.redis.hooks.redis.RedisHook", "redis_conn_id"),
"snowflake": ("airflow.providers.snowflake.hooks.snowflake.SnowflakeHook", "snowflake_conn_id"),
"sqlite": ("airflow.providers.sqlite.hooks.sqlite.SqliteHook", "sqlite_conn_id"),
"tableau": ("airflow.providers.salesforce.hooks.tableau.TableauHook", "tableau_conn_id"),
"vertica": ("airflow.providers.vertica.hooks.vertica.VerticaHook", "vertica_conn_id"),
"wasb": ("airflow.providers.microsoft.azure.hooks.wasb.WasbHook", "wasb_conn_id"),
}
# PLEASE KEEP ABOVE LIST IN ALPHABETICAL ORDER.


def parse_netloc_to_hostname(*args, **kwargs):
"""This method is deprecated."""
Expand Down Expand Up @@ -326,7 +266,8 @@ def rotate_fernet_key(self):

def get_hook(self):
"""Return hook based on conn_type."""
hook_class_name, conn_id_param = CONN_TYPE_TO_HOOK.get(self.conn_type, (None, None))
hook_class_name, conn_id_param = ProvidersManager().hooks.get(self.conn_type, (None, None))

if not hook_class_name:
raise AirflowException(f'Unknown hook type "{self.conn_type}"')
hook_class = import_string(hook_class_name)
Expand Down
18 changes: 1 addition & 17 deletions airflow/plugins_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import importlib_metadata

from airflow import settings
from airflow.utils.entry_points_with_dist import entry_points_with_dist
from airflow.utils.file import find_path_from_directory

if TYPE_CHECKING:
Expand Down Expand Up @@ -170,23 +171,6 @@ def is_valid_plugin(plugin_obj):
return False


def entry_points_with_dist(group: str):
"""
Return EntryPoint objects of the given group, along with the distribution information.
This is like the ``entry_points()`` function from importlib.metadata,
except it also returns the distribution the entry_point was loaded from.
:param group: FIlter results to only this entrypoint group
:return: Generator of (EntryPoint, Distribution) objects for the specified groups
"""
for dist in importlib_metadata.distributions():
for e in dist.entry_points:
if e.group != group:
continue
yield (e, dist)


def load_entrypoint_plugins():
"""
Load and register plugins AirflowPlugin subclasses from the entrypoints.
Expand Down
7 changes: 7 additions & 0 deletions airflow/provider.yaml.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,13 @@
"python-module"
]
}
},
"hook-class-names": {
"type": "array",
"description": "Hook class names that provide connection types to core",
"items": {
"type": "string"
}
}
},
"additionalProperties": false,
Expand Down
6 changes: 5 additions & 1 deletion airflow/providers/apache/cassandra/hooks/cassandra.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,11 @@ class CassandraHook(BaseHook, LoggingMixin):
For details of the Cluster config, see cassandra.cluster.
"""

def __init__(self, cassandra_conn_id: str = 'cassandra_default'):
conn_name_attr = 'cassandra_conn_id'
default_conn_name = 'cassandra_default'
conn_type = 'cassandra'

def __init__(self, cassandra_conn_id: str = default_conn_name):
super().__init__()
conn = self.get_connection(cassandra_conn_id)

Expand Down
3 changes: 3 additions & 0 deletions airflow/providers/apache/cassandra/provider.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,6 @@ hooks:
- integration-name: Apache Cassandra
python-modules:
- airflow.providers.apache.cassandra.hooks.cassandra

hook-class-names:
- airflow.providers.apache.cassandra.hooks.cassandra.CassandraHook
7 changes: 6 additions & 1 deletion airflow/providers/apache/hive/hooks/hive.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,13 @@ class HiveCliHook(BaseHook):
:type mapred_job_name: str
"""

conn_name_attr = 'hive_cli_conn_id'
default_conn_name = 'hive_cli_default'
conn_type = 'hive_cli'

def __init__(
self,
hive_cli_conn_id: str = "hive_cli_default",
hive_cli_conn_id: str = default_conn_name,
run_as: Optional[str] = None,
mapred_queue: Optional[str] = None,
mapred_queue_priority: Optional[str] = None,
Expand Down Expand Up @@ -809,6 +813,7 @@ class HiveServer2Hook(DbApiHook):

conn_name_attr = 'hiveserver2_conn_id'
default_conn_name = 'hiveserver2_default'
conn_type = 'hiveserver2'
supports_autocommit = False

def get_conn(self, schema: Optional[str] = None) -> Any:
Expand Down
4 changes: 4 additions & 0 deletions airflow/providers/apache/hive/provider.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,7 @@ transfers:
- source-integration-name: Microsoft SQL Server (MSSQL)
target-integration-name: Apache Hive
python-module: airflow.providers.apache.hive.transfers.mssql_to_hive

hook-class-names:
- airflow.providers.apache.hive.hooks.hive.HiveCliHook
- airflow.providers.apache.hive.hooks.hive.HiveServer2Hook
6 changes: 5 additions & 1 deletion airflow/providers/apache/pig/hooks/pig.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,11 @@ class PigCliHook(BaseHook):
"""

def __init__(self, pig_cli_conn_id: str = "pig_cli_default") -> None:
conn_name_attr = 'pig_cli_conn_id'
default_conn_name = 'pig_cli_default'
conn_type = 'pig_cli'

def __init__(self, pig_cli_conn_id: str = default_conn_name) -> None:
super().__init__()
conn = self.get_connection(pig_cli_conn_id)
self.pig_properties = conn.extra_dejson.get('pig_properties', '')
Expand Down
4 changes: 4 additions & 0 deletions airflow/providers/apache/pig/provider.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,11 @@ operators:
- integration-name: Apache Pig
python-modules:
- airflow.providers.apache.pig.operators.pig

hooks:
- integration-name: Apache Pig
python-modules:
- airflow.providers.apache.pig.hooks.pig

hook-class-names:
- airflow.providers.apache.pig.hooks.pig.PigCliHook
6 changes: 5 additions & 1 deletion airflow/providers/cloudant/hooks/cloudant.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,11 @@ class CloudantHook(BaseHook):
:type cloudant_conn_id: str
"""

def __init__(self, cloudant_conn_id: str = 'cloudant_default') -> None:
conn_name_attr = 'cloudant_conn_id'
default_conn_name = 'cloudant_default'
conn_type = 'cloudant'

def __init__(self, cloudant_conn_id: str = default_conn_name) -> None:
super().__init__()
self.cloudant_conn_id = cloudant_conn_id

Expand Down
3 changes: 3 additions & 0 deletions airflow/providers/cloudant/provider.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,6 @@ hooks:
- integration-name: IBM Cloudant
python-modules:
- airflow.providers.cloudant.hooks.cloudant

hook-class-names:
- airflow.providers.cloudant.hooks.cloudant.CloudantHook
6 changes: 5 additions & 1 deletion airflow/providers/cncf/kubernetes/hooks/kubernetes.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ class KubernetesHook(BaseHook):
:type conn_id: str
"""

conn_name_attr = 'kubernetes_conn_id'
default_conn_name = 'kubernetes_default'
conn_type = 'kubernetes'

def __init__(
self, conn_id: str = "kubernetes_default", client_configuration: Optional[client.Configuration] = None
self, conn_id: str = default_conn_name, client_configuration: Optional[client.Configuration] = None
) -> None:
super().__init__()
self.conn_id = conn_id
Expand Down
3 changes: 3 additions & 0 deletions airflow/providers/cncf/kubernetes/provider.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,6 @@ hooks:
- integration-name: Kubernetes
python-modules:
- airflow.providers.cncf.kubernetes.hooks.kubernetes

hook-class-names:
- airflow.providers.cncf.kubernetes.hooks.kubernetes.KubernetesHook
6 changes: 5 additions & 1 deletion airflow/providers/docker/hooks/docker.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,13 @@ class DockerHook(BaseHook, LoggingMixin):
:type docker_conn_id: str
"""

conn_name_attr = 'docker_conn_id'
default_conn_name = 'docker_default'
conn_type = 'docker'

def __init__(
self,
docker_conn_id='docker_default',
docker_conn_id: str = default_conn_name,
base_url: Optional[str] = None,
version: Optional[str] = None,
tls: Optional[str] = None,
Expand Down
3 changes: 3 additions & 0 deletions airflow/providers/docker/provider.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,6 @@ hooks:
- integration-name: Docker
python-modules:
- airflow.providers.docker.hooks.docker

hook-class-names:
- airflow.providers.docker.hooks.docker.DockerHook
1 change: 1 addition & 0 deletions airflow/providers/elasticsearch/hooks/elasticsearch.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ class ElasticsearchHook(DbApiHook):

conn_name_attr = 'elasticsearch_conn_id'
default_conn_name = 'elasticsearch_default'
conn_type = 'elasticsearch'

def __init__(self, schema: str = "http", connection: Optional[AirflowConnection] = None, *args, **kwargs):
super().__init__(*args, **kwargs)
Expand Down
3 changes: 3 additions & 0 deletions airflow/providers/elasticsearch/provider.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,6 @@ hooks:
- integration-name: Elasticsearch
python-modules:
- airflow.providers.elasticsearch.hooks.elasticsearch

hook-class-names:
- airflow.providers.elasticsearch.hooks.elasticsearch.ElasticsearchHook
1 change: 1 addition & 0 deletions airflow/providers/exasol/hooks/exasol.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ class ExasolHook(DbApiHook):

conn_name_attr = 'exasol_conn_id'
default_conn_name = 'exasol_default'
conn_type = 'exasol'
supports_autocommit = True

def __init__(self, *args, **kwargs) -> None:
Expand Down
3 changes: 3 additions & 0 deletions airflow/providers/exasol/provider.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,6 @@ hooks:
- integration-name: Exasol
python-modules:
- airflow.providers.exasol.hooks.exasol

hook-class-names:
- airflow.providers.exasol.hooks.exasol.ExasolHook
4 changes: 3 additions & 1 deletion airflow/providers/google/cloud/hooks/bigquery.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,9 @@
class BigQueryHook(GoogleBaseHook, DbApiHook):
"""Interact with BigQuery. This hook uses the Google Cloud connection."""

conn_name_attr = 'gcp_conn_id' # type: str
conn_name_attr = 'gcp_conn_id'
default_conn_name = 'google_cloud_default'
conn_type = 'google_cloud_platform'

def __init__(
self,
Expand Down
7 changes: 6 additions & 1 deletion airflow/providers/google/cloud/hooks/cloud_sql.py
Original file line number Diff line number Diff line change
Expand Up @@ -709,6 +709,11 @@ class CloudSQLDatabaseHook(BaseHook): # noqa
in the connection URL
:type default_gcp_project_id: str
"""

conn_name_attr = 'gcp_cloudsql_conn_id'
default_conn_name = 'google_cloud_sql_default'
conn_type = 'gcpcloudsql'

_conn = None # type: Optional[Any]

def __init__(
Expand All @@ -735,7 +740,7 @@ def __init__(
self.user = self.cloudsql_connection.login # type: Optional[str]
self.password = self.cloudsql_connection.password # type: Optional[str]
self.public_ip = self.cloudsql_connection.host # type: Optional[str]
self.public_port = self.cloudsql_connection.port # type: Optional[str]
self.public_port = self.cloudsql_connection.port # type: Optional[int]
self.sslcert = self.extras.get('sslcert') # type: Optional[str]
self.sslkey = self.extras.get('sslkey') # type: Optional[str]
self.sslrootcert = self.extras.get('sslrootcert') # type: Optional[str]
Expand Down
Loading

0 comments on commit f7019d0

Please sign in to comment.