Monitoring: Asset Deviation #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## Develop #864 +/- ##
========================================
Coverage 39.55% 39.55%
========================================
Files 48 48
Lines 2996 2996
========================================
Hits 1185 1185
Misses 1811 1811 ☔ View full report in Codecov by Sentry. |
zktony
reviewed
Aug 28, 2023
Gauthamastro
added
A0-PleaseReview
Gauthamastro
added
A0-PleaseReview
There was a problem hiding this comment.
This module lacks documentation and license
| pub fn release_offchain_lock() { | ||
| // Check if another worker is already running or not | ||
| let s_info = StorageValueRef::persistent(&WORKER_STATUS); | ||
| s_info.set(&false); // Set WORKER_STATUS to true |
There was a problem hiding this comment.
Why comment says set to true and s_info.set(&false) set's false?
Comment on lines
+53
to
+56
| pub fn get_balances( | ||
| state: &mut OffchainState, | ||
| account: &AccountId, | ||
| ) -> Result<BTreeMap<AssetId, Decimal>, &'static str> { |
| for (main, _) in <Accounts<T>>::iter() { | ||
| // 3. Compute sum of all balances of all assets | ||
| let balances: BTreeMap<AssetId, Decimal> = | ||
| Self::get_balances(&mut state, &Decode::decode(&mut &main.encode()[..]).unwrap())?; |
There was a problem hiding this comment.
Shouldn't unwrap be replaced with proper result handling?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Polkadex-Substrate/issue-tracker/issues/240