Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Checkpoint Handler #865

Merged
merged 12 commits into from
Aug 31, 2023
Merged

Implemented Checkpoint Handler #865

merged 12 commits into from
Aug 31, 2023

Conversation

zktony
Copy link
Contributor

@zktony zktony commented Aug 25, 2023

Implemented RPC to retrieve Checkpoints from Offchain Storage.

@zktony zktony requested review from Gauthamastro and serhii-temchenko and removed request for Gauthamastro August 25, 2023 13:47
@zktony zktony added the A0-PleaseReview Pull request needs code review. label Aug 25, 2023
Copy link
Contributor

@serhii-temchenko serhii-temchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the CI

pallets/ocex/rpc/Cargo.toml Outdated Show resolved Hide resolved
pallets/ocex/rpc/Cargo.toml Outdated Show resolved Hide resolved
pallets/ocex/rpc/Cargo.toml Outdated Show resolved Hide resolved
pallets/ocex/rpc/Cargo.toml Outdated Show resolved Hide resolved
pallets/ocex/rpc/src/offchain.rs Outdated Show resolved Hide resolved
pallets/ocex/src/validator.rs Outdated Show resolved Hide resolved
pallets/thea/src/aggregator.rs Outdated Show resolved Hide resolved
primitives/orderbook/src/lib.rs Outdated Show resolved Hide resolved
primitives/orderbook/src/lib.rs Outdated Show resolved Hide resolved
primitives/orderbook/src/lib.rs Outdated Show resolved Hide resolved
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Aug 28, 2023
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Aug 28, 2023
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Aug 29, 2023
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

❗ No coverage uploaded for pull request base (zk-reorg@430b586). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             zk-reorg     #865   +/-   ##
===========================================
  Coverage            ?   37.22%           
===========================================
  Files               ?       53           
  Lines               ?     3183           
  Branches            ?        0           
===========================================
  Hits                ?     1185           
  Misses              ?     1998           
  Partials            ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Aug 30, 2023
@Gauthamastro Gauthamastro merged commit 51f56f3 into zk-reorg Aug 31, 2023
3 checks passed
@Gauthamastro Gauthamastro deleted the zk-impl-snapshot branch August 31, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants