Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pallets weight #876

Merged
merged 38 commits into from
Nov 1, 2023
Merged

Updated pallets weight #876

merged 38 commits into from
Nov 1, 2023

Conversation

serhii-temchenko
Copy link
Contributor

@serhii-temchenko serhii-temchenko commented Oct 24, 2023

Describe your changes

After substrate version update in PR #870 weights of pallets should be updated.
In this PR newly generated weights are provided.

Issue ticket number and link

#241

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I removed all Clippy and Formatting Warnings.
  • I added required Copyrights.

⚠️ Note that parachain related pallets weights (e.g. thea-council and xcm-helper) didn't updated because of error:

Error: Input("Did not find the benchmarking metadata. This could mean that you either did not build the node correctly with the --features runtime-benchmarks flag, or the chain spec that you are using was not created by a node that was compiled with the flag: Other: Exported method Benchmark_benchmark_metadata is not found")

Even though --features runtime-benchmarks flag provided on the build process.
@zktony please check this problem.
Fixed.

@serhii-temchenko serhii-temchenko added the A3-InProgress Pull request is in progress. No review needed at this stage. label Oct 24, 2023
@serhii-temchenko serhii-temchenko self-assigned this Oct 24, 2023
@serhii-temchenko serhii-temchenko added A0-PleaseReview Pull request needs code review. and removed A3-InProgress Pull request is in progress. No review needed at this stage. labels Oct 31, 2023
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 366 lines in your changes are missing coverage. Please review.

Comparison is base (bbe2ed9) 36.29% compared to head (90de23b) 36.11%.
Report is 28 commits behind head on zk-reorg.

Additional details and impacted files
@@             Coverage Diff              @@
##           zk-reorg     #876      +/-   ##
============================================
- Coverage     36.29%   36.11%   -0.18%     
============================================
  Files            54       62       +8     
  Lines          3257     3694     +437     
============================================
+ Hits           1182     1334     +152     
- Misses         2075     2360     +285     
Files Coverage Δ
client/src/lib.rs 0.00% <ø> (ø)
nodes/mainnet/src/chain_spec.rs 0.00% <ø> (ø)
pallets/liquidity/src/benchmarking.rs 0.00% <ø> (ø)
pallets/ocex/rpc/src/lib.rs 0.00% <ø> (ø)
pallets/ocex/src/benchmarking.rs 0.00% <ø> (ø)
pallets/ocex/src/storage.rs 75.60% <ø> (ø)
pallets/pdex-migration/src/lib.rs 79.82% <100.00%> (ø)
pallets/rewards/rpc/src/lib.rs 0.00% <ø> (ø)
pallets/rewards/src/benchmarking.rs 0.00% <ø> (ø)
pallets/rewards/src/lib.rs 59.18% <ø> (ø)
... and 30 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gauthamastro Gauthamastro merged commit fbca50b into zk-reorg Nov 1, 2023
3 checks passed
@Gauthamastro Gauthamastro deleted the feat/it-241/weights branch November 1, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants