Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Governance controlled burn extrinsic for native tokens #892

Merged
merged 5 commits into from
Dec 28, 2023

Conversation

Gauthamastro
Copy link
Member

Describe your changes

Added an extrinsic to burn native token based on a governance proposal

@serhii-temchenko @zktony We will do proper benchmarking of this extrinsic later, and parachain withdraw is good enough to unblock its voting now. Added a TODO for it.

@Gauthamastro Gauthamastro self-assigned this Dec 27, 2023
@Gauthamastro Gauthamastro added the A0-PleaseReview Pull request needs code review. label Dec 27, 2023
@Gauthamastro Gauthamastro added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Dec 28, 2023
@Gauthamastro Gauthamastro added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Dec 28, 2023
@Gauthamastro Gauthamastro added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (5f0f730) 37.25% compared to head (e38bf80) 37.33%.

Files Patch % Lines
pallets/thea-executor/src/lib.rs 0.00% 9 Missing ⚠️
pallets/thea/src/aggregator.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           Develop     #892      +/-   ##
===========================================
+ Coverage    37.25%   37.33%   +0.07%     
===========================================
  Files           63       63              
  Lines         3777     3769       -8     
===========================================
  Hits          1407     1407              
+ Misses        2370     2362       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gauthamastro Gauthamastro merged commit a101488 into Develop Dec 28, 2023
3 checks passed
@Gauthamastro Gauthamastro deleted the gj/add-burn-extrinsic branch December 28, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants