Added tests for OCEX and LMP Pallet #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zktony
changed the title
Gauthamastro
requested changes
Jan 10, 2024
There was a problem hiding this comment.
Existing unit tests of validator logic should not be ignored. The rest we can review, @zktony
serhii-temchenko
requested changes
Jan 10, 2024
| @@ -163,9 +163,10 @@ impl<T: Config> LiquidityMiningCrowdSourcePallet<T::AccountId> for Pallet<T> { | |||
| .to_u128() | |||
| .ok_or(Error::<T>::ConversionError)? | |||
| .saturated_into(); | |||
| //FIXME: What are we doing with base_freed and quote_freed? | |||
There was a problem hiding this comment.
When it should be discussed and fixed? in scope of this PR?
There was a problem hiding this comment.
Will be fixed in @Gauthamastro PR
| &pool_config.pool_id, | ||
| &lp, | ||
| quote_amt_to_claim, | ||
| Preservation::Expendable, | ||
| )?; | ||
| // TODO: Emit events | ||
| // TODO: Emit events (Ask @frontend team about this) |
There was a problem hiding this comment.
Will be fixed in @Gauthamastro PR
# Conflicts: # Cargo.lock # pallets/liquidity-mining/Cargo.toml # primitives/orderbook/src/lib.rs
Gauthamastro
added
A0-PleaseReview
Gauthamastro
added
A0-PleaseReview
Gauthamastro
added
A0-PleaseReview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added tests for OCEX and LP Pallet.