-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix filter on Proxy pallet to allow all extrinsics if ProxyType::Any #945
Fix filter on Proxy pallet to allow all extrinsics if ProxyType::Any #945
Conversation
## Describe your changes Enchancements to LMP and automating OB withdrawals. ## Issue ticket number and link ## Checklist before requesting a review - [ ] I have performed a self-review of my code. - [ ] If it is a core feature, I have added thorough tests. - [ ] I removed all Clippy and Formatting Warnings. - [ ] I added required Copyrights.
## Describe your changes 1. Add Saturating sub for close auction calculations 2. Add more events in Thea executor 3. Fixed fetch_checkpoint API 4. Removed typos ## Checklist before requesting a review - [x] I have performed a self-review of my code. - [ ] If it is a core feature, I have added thorough tests. - [x] I removed all Clippy and Formatting Warnings. - [x] I added required Copyrights.
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
6181bae
into
Polkadex-Substrate:Develop
There is a filter on ProxyType::Any to remove the ability to do anything. This changes it to the intended purpose, to allow any.
This was changed to false on 9/12/21 in this commit:
9c18e2b
It should be set to true as the intent of ProxyType::Any is to allow all.
It can be seen set to any in other chain implementations:
https://github.com/moonbeam-foundation/moonbeam/blob/f99b3ef04c560ab47ad7d569d968808a040a0cd0/runtime/moonbeam/src/lib.rs#L1016
https://github.com/paritytech/substrate/blob/033d4e86cc7eff0066cd376b9375f815761d653c/bin/node/runtime/src/lib.rs#L372
Checklist before requesting a review