Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended XCM Test Cases #962

Merged
merged 10 commits into from
May 31, 2024
Merged

Extended XCM Test Cases #962

merged 10 commits into from
May 31, 2024

Conversation

zktony
Copy link
Contributor

@zktony zktony commented May 29, 2024

Describe your changes

Extended XCM Test Cases.

Copy link
Contributor

coderabbitai bot commented May 29, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Gauthamastro Gauthamastro added the A0-PleaseReview Pull request needs code review. label May 30, 2024
@Gauthamastro Gauthamastro changed the base branch from mainnet-release to Develop May 30, 2024 07:13
Copy link
Member

@Gauthamastro Gauthamastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zktony Where are the test cases in simulator for sending PDEX from mainnet to parachain

pallets/xcm-helper/src/lib.rs Show resolved Hide resolved
pallets/xcm-helper/src/lib.rs Outdated Show resolved Hide resolved
pallets/xcm-helper/src/lib.rs Outdated Show resolved Hide resolved
pallets/xcm-helper/src/lib.rs Show resolved Hide resolved
pallets/xcm-helper/src/lib.rs Show resolved Hide resolved
pallets/xcm-helper/src/lib.rs Show resolved Hide resolved
pallets/xcm-helper/src/lib.rs Show resolved Hide resolved
pallets/xcm-helper/src/lib.rs Show resolved Hide resolved
pallets/xcm-helper/src/lib.rs Outdated Show resolved Hide resolved
polkadex-xcm-simulator/Cargo.toml Outdated Show resolved Hide resolved
@zktony zktony requested a review from Gauthamastro May 30, 2024 10:41
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels May 30, 2024
@zktony
Copy link
Contributor Author

zktony commented May 30, 2024

@zktony Where are the test cases in simulator for sending PDEX from mainnet to parachain

fn test_on_initialize_with_non_native_asset_deposit_to_polkadex_parachain() {

@Gauthamastro
Copy link
Member

@zktony Where are the test cases in simulator for sending PDEX from mainnet to parachain

fn test_on_initialize_with_non_native_asset_deposit_to_polkadex_parachain() {

Update the name, from non-native to native. Its misleading

@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels May 30, 2024
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels May 30, 2024
pallets/xcm-helper/src/lib.rs Show resolved Hide resolved
pallets/xcm-helper/src/lib.rs Show resolved Hide resolved
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 43.19527% with 96 lines in your changes are missing coverage. Please review.

Project coverage is 42.34%. Comparing base (f915583) to head (d46a3d4).

Files Patch % Lines
pallets/xcm-helper/src/lib.rs 43.39% 60 Missing ⚠️
polkadex-xcm-simulator/src/parachain.rs 22.22% 35 Missing ⚠️
primitives/polkadex/src/assets.rs 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           Develop     #962      +/-   ##
===========================================
+ Coverage    40.44%   42.34%   +1.90%     
===========================================
  Files           72       72              
  Lines         5786     5915     +129     
===========================================
+ Hits          2340     2505     +165     
+ Misses        3446     3410      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Gauthamastro Gauthamastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two failure events are missing

@zktony zktony requested a review from Gauthamastro May 31, 2024 05:34
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels May 31, 2024
@Gauthamastro Gauthamastro merged commit 38b9bec into Develop May 31, 2024
3 checks passed
@Gauthamastro Gauthamastro deleted the ksr/added-xcm-tests branch May 31, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants