-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom header buttons layouts #30
Support custom header buttons layouts #30
Conversation
found few things to improve during self review, will move to draft for a short moment |
ddafd1b
to
f4d276d
Compare
f4d276d
to
0df296c
Compare
It's ready for checking now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome!
Just some minor comments about stylistic stuff.
@PolyMeilex |
Ok, looks great now, just one more comment that I noticed, and some more testing and this should be good to go! |
Co-authored-by: Bartłomiej Maryńczak <[email protected]>
Might I suggest utilizing |
Sadly ashpd with zbus would probably pull in more dependencies then this whole crate. Which is a big blocker, for small decorations crate. It would probably be better fitted in winit where we could integrate it with event loop, and update settings on the fly rather than once on startup, but I'm not sure if heavy deps like zbus are welcome in winit either (I actually don't know, haven't asked around). |
Thank you! |
Closes #27
In this MR I've generalized the button structure and it is now possible to have custom layouts in window headers similar to what you can have in Gnome apps or classic Xorg WMs.
Obvious use case for this would be to have buttons moved to the left side (like Unity):
But other possible layout combinations should work, too:
or even something crazy like
Also should be extendable if we will (ever) have an app menu button.
I didn't have any experience in rust so far, thus feedback is more than welcomed.