Background support #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 10, 2018 13:22
- Use common parser definitions from parse_utils - Factor out an eol() parser into parse utils to match either newline or eof.
Previously, TestCase was a trait, and features were composed of boxed TestCase trait objects. This changes it to an enum, since we expect to have only a small number of TestCase types, and users are not expected to provide new ones. This also changes the module layout; previously, the scenario and feature parsers and AST structs were each in their own modules. This makes less sense when using the enum at the TestCase level. Now all the AST structs are in the AST module, and the parsers are in the parser module.
This adds support for a Background section in the spec, which is executed before each test case to initialize its context. - Add a TestResult struct, used at the TestCase level to bundle together success, the test case name, and the test context.
| return TestResult { | ||
| test_case_name: match self.name.as_ref() { | ||
| Some(s) => s.clone(), | ||
| None => "".to_string() |
There was a problem hiding this comment.
I'm not sure what is more idiomatic, but in cases like this I usually use String::new()
| } | ||
|
|
||
| /// A specific step which makes up a scenario. Users should create their own | ||
| /// implementations of this trait, which are returned by their step parsers. |
There was a problem hiding this comment.
For rustdoc, I think the first line is supposed to be a summary of the functionality and then more details get added after a blank line. I think so it renders nicer?
| // "#; | ||
|
|
||
| // assert!(true) | ||
| // } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.