Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use spawn_local with bazel to work around path include issue. #4013

Closed
wants to merge 1 commit into from
Closed

Use spawn_local with bazel to work around path include issue. #4013

wants to merge 1 commit into from

Conversation

shaper
Copy link
Contributor

@shaper shaper commented Nov 6, 2019 •
edited
Loading

csilvestrini
csilvestrini approved these changes Nov 6, 2019
View reviewed changes
Copy link
Collaborator

@csilvestrini csilvestrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Assuming this works, LGTM

@shaper
Copy link
Contributor Author

shaper commented Nov 6, 2019

This doesn't seem to have been sufficient. @cromwellian sees a few other flags we might want to try here: https://docs.bazel.build/versions/master/command-line-reference.html#flag--experimental_sandboxfs_map_symlink_targets

There are many docker/sandbox related experimental flags there.

@shaper shaper mentioned this pull request Nov 6, 2019
Closed
@shaper shaper closed this Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csilvestrini csilvestrini csilvestrini approved these changes

@cromwellian cromwellian cromwellian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaper @cromwellian @csilvestrini