Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated verify_policy tool #7142

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

alxmrs
Copy link
Contributor

@alxmrs alxmrs commented Apr 30, 2021

  • Added flag to turn on debug mode.
  • made CLI more conventional
  • documented tool
  • added a few more log stmts

CC: @cromwellian, @jasonwyatt, @csilvestrini

- Added flag to turn on debug mode.
- made CLI more conventional
- documented tool
- added a few more log stmts
@alxmrs alxmrs requested a review from bgogul April 30, 2021 23:12
@google-cla google-cla bot added the cla: yes label Apr 30, 2021
Copy link
Collaborator

@bgogul bgogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additional log statements can result in too much debug information. Can we remove them?

@@ -693,8 +693,14 @@ private fun Predicate.labels(): List<InformationFlowLabel> = when (this) {

/** Returns true if the [check] is satisfied by the labels computed for [particle]. */
fun InformationFlow.AnalysisResult.verify(particle: Recipe.Particle, check: Check): Boolean {
val log = TaggedLog { "AnalysisResult.verify" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too much debug information. Let us not keep these log.debug statements.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, just pushed a reversion.


override fun run() {
if (debug) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My pleasure!

@alxmrs alxmrs requested a review from bgogul May 3, 2021 18:00
@alxmrs alxmrs added the ready to pull Add this label to pull a PR into google. label May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull Add this label to pull a PR into google.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants