Switch to internal files directory for storing books #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: starry-shivam <[email protected]>
Signed-off-by: starry-shivam <[email protected]>
Signed-off-by: starry-shivam <[email protected]>
starry-shivam
changed the title
Ref #128 (comment) Signed-off-by: starry-shivam <[email protected]>
Merged
starry-shivam
added a commit
that referenced
this pull request
Mar 22, 2024
Removed declaration of storage permission as it is no longer needed from v3.2.0, See #129 for more information. Some other grammatical fixes for better clarity and readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to internal files directory for storing books instead of using external download directory
This fixes the issue of books failing to open randomly over time due to the app losing access to EPUB files it created. This loss of access can occur for various reasons, such as uninstalling and reinstalling the app, MediaStore reindexing, or another app gaining access to the download directory, resulting in write/read access loss. These issues are difficult to reproduce. Two possible fixes I can think of are requesting access to all files, as file managers do, or switching to the app-specific internal files directory. The former option, of course, makes no sense, so we're going with the latter. If you need access to the EPUB file of a certain book, you can always swipe right to save or share it anywhere you like.
While on that also fixed issue with books not getting saved in library when using multi user mode / work profiles due to hard coded primary user (../0) in filepath.