fix(nginx): set service-upstream to "true" #532
Merged
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having NGINX maintain it's own list of upstreams, we want it instead to use the service ClusterIP such that k8s can handle e.g. cases where pods are evicted. Without this we end up with 5xx errors e.g. on deploys. See kubernetes/ingress-nginx#257 for more details.
ellie
approved these changes
Aug 17, 2022
|
Good 🔎 team (part #2). Good to confirm that's what we've suspected yesterday 💪 |
guidoiaquinti
approved these changes
Aug 17, 2022
hazzadous
added
bump patch
hazzadous
added a commit
that referenced
this pull request
Aug 24, 2022
This reverts commit 249f62e.
hazzadous
pushed a commit
that referenced
this pull request
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having NGINX maintain it's own list of upstreams, we want it
instead to use the service ClusterIP such that k8s can handle e.g. cases
where pods are evicted.
Without this we end up with 5xx errors e.g. on deploys. See
kubernetes/ingress-nginx#257 for more details.
Description
Type of change
How has this been tested?
Checklist