-
Notifications
You must be signed in to change notification settings - Fork 5
Rework console extension to send data to Kafka>ClickHouse or Postgres #318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sincerely naive question, but how come not just use Postgres for this given we still store data there for both EE and FOSS? Is it a matter of future-proofing and keeping as much of the new additions specific to one db?
Given the potentially high data volume nature of this feature, ClickHouse is definitely more future-proof and only marginally more complicated. @yakkomajuri |
Tests are still expecting stuff like Either way, if the answer is no, I guess tests still have to be updated |
Yep, adjusted for that @yakkomajuri. FYI in-plugin |
PR reviewable. Top green check is the end goal state - persistent console fully tested and enabled by default. That ran with PostHog/posthog#3482 as the main repo base though, so until that is merged into main repo master, the version merged will have some |
This reverts commit 2e5f652.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Merge whenever convenient.
…ouse or Postgres (PostHog/plugin-server#318) * Rework console extension to send data to Kafka>ClickHouse or Postgres * Fix object stringification in console * Log ConsoleExtension to stdout in dev * Hide rework behind ENABLE_PERSISTENT_CONSOLE setting * Add tests * Run CI in respect to main repo plugin-log-entries branch * Update sql.ts * Fix tests * Update plugins.test.ts * Don't run console tests if ENABLE_PERSISTENT_CONSOLE false * Use plugin_config_id in plugin log entry * Improve persistent console value formatting * Do run console tests if ENABLE_PERSISTENT_CONSOLE false * Revert "Do run console tests if ENABLE_PERSISTENT_CONSOLE false" This reverts commit 2e5f652b39e65eb2e612de38dc4cec21baa6842b.
Changes
Plugin server changes for PostHog/posthog#3482.
Checklist