-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(feature-flags): JSON payload function #81
Changes from all commits
116df0c
86357f2
3a17397
ff0efcc
034842c
3b98025
5f6ae54
3a96d45
b3db682
761f243
2025c40
6fc74a7
6df1b5d
b8f7bca
5df1939
b97bbe6
7e91cec
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -63,7 +63,7 @@ def _process_response( | |
|
||
def decide(api_key: str, host: Optional[str] = None, gzip: bool = False, timeout: int = 15, **kwargs) -> Any: | ||
"""Post the `kwargs to the decide API endpoint""" | ||
res = post(api_key, host, "/decide/?v=2", gzip, timeout, **kwargs) | ||
res = post(api_key, host, "/decide/?v=3", gzip, timeout, **kwargs) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is the resiliency stuff in a separate pr? 😅 (I'm hoping you're handling that too 😬 ) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmmm, what resiliency needs to be added here. All the 200 checking is handled within There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sounds good to me! |
||
return _process_response(res, success_message="Feature flags decided successfully") | ||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to go in
__init__.py
for the interface to be available.Also add to
example.py
to test locally that everything works :)