-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Introduce Path Persons API endpoint (#6070)
* introduce path persons API endpoint * docs in query class
- Loading branch information
1 parent
bb0826c
commit 9e970d3
Showing
6 changed files
with
225 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
151 changes: 151 additions & 0 deletions
151
ee/clickhouse/views/test/test_clickhouse_path_person.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,151 @@ | ||
| from unittest.mock import patch | ||
| from uuid import uuid4 | ||
|
|
||
| from django.core.cache import cache | ||
| from rest_framework import status | ||
|
|
||
| from ee.clickhouse.models.event import create_event | ||
| from ee.clickhouse.util import ClickhouseTestMixin | ||
| from posthog.constants import INSIGHT_PATHS | ||
| from posthog.models.person import Person | ||
| from posthog.test.base import APIBaseTest | ||
|
|
||
|
|
||
| def _create_person(**kwargs): | ||
| person = Person.objects.create(**kwargs) | ||
| return person | ||
|
|
||
|
|
||
| def _create_event(**kwargs): | ||
| kwargs.update({"event_uuid": uuid4()}) | ||
| create_event(**kwargs) | ||
|
|
||
|
|
||
| class TestPathPerson(ClickhouseTestMixin, APIBaseTest): | ||
| def _create_sample_data(self, num, delete=False): | ||
| for i in range(num): | ||
| person = _create_person(distinct_ids=[f"user_{i}"], team=self.team) | ||
| _create_event( | ||
| event="step one", | ||
| distinct_id=f"user_{i}", | ||
| team=self.team, | ||
| timestamp="2021-05-01 00:00:00", | ||
| properties={"$browser": "Chrome"}, | ||
| ) | ||
| if i % 2 == 0: | ||
| _create_event( | ||
| event="step two", | ||
| distinct_id=f"user_{i}", | ||
| team=self.team, | ||
| timestamp="2021-05-01 00:10:00", | ||
| properties={"$browser": "Chrome"}, | ||
| ) | ||
| _create_event( | ||
| event="step three", | ||
| distinct_id=f"user_{i}", | ||
| team=self.team, | ||
| timestamp="2021-05-01 00:20:00", | ||
| properties={"$browser": "Chrome"}, | ||
| ) | ||
| if delete: | ||
| person.delete() | ||
|
|
||
| def test_basic_format(self): | ||
| self._create_sample_data(5) | ||
| request_data = { | ||
| "insight": INSIGHT_PATHS, | ||
| "filter_test_accounts": "false", | ||
| "date_from": "2021-05-01", | ||
| "date_to": "2021-05-10", | ||
| } | ||
|
|
||
| response = self.client.get("/api/person/path/", data=request_data) | ||
| self.assertEqual(response.status_code, status.HTTP_200_OK) | ||
| j = response.json() | ||
| first_person = j["results"][0]["people"][0] | ||
| self.assertEqual(5, len(j["results"][0]["people"])) | ||
| self.assertTrue("id" in first_person and "name" in first_person and "distinct_ids" in first_person) | ||
| self.assertEqual(5, j["results"][0]["count"]) | ||
|
|
||
| def test_basic_format_with_path_start_key_constraints(self): | ||
| self._create_sample_data(5) | ||
| request_data = { | ||
| "insight": INSIGHT_PATHS, | ||
| "filter_test_accounts": "false", | ||
| "date_from": "2021-05-01", | ||
| "date_to": "2021-05-10", | ||
| "path_start_key": "2_step two", | ||
| } | ||
|
|
||
| response = self.client.get("/api/person/path/", data=request_data) | ||
| self.assertEqual(response.status_code, status.HTTP_200_OK) | ||
| j = response.json() | ||
| first_person = j["results"][0]["people"][0] | ||
| self.assertEqual(3, len(j["results"][0]["people"])) | ||
| self.assertTrue("id" in first_person and "name" in first_person and "distinct_ids" in first_person) | ||
| self.assertEqual(3, j["results"][0]["count"]) | ||
|
|
||
| def test_basic_format_with_start_point_constraints(self): | ||
| self._create_sample_data(7) | ||
| request_data = { | ||
| "insight": INSIGHT_PATHS, | ||
| "filter_test_accounts": "false", | ||
| "date_from": "2021-05-01", | ||
| "date_to": "2021-05-10", | ||
| "path_start_key": "1_step two", | ||
| "start_point": "step two", | ||
| } | ||
|
|
||
| response = self.client.get("/api/person/path/", data=request_data) | ||
| self.assertEqual(response.status_code, status.HTTP_200_OK) | ||
| j = response.json() | ||
| first_person = j["results"][0]["people"][0] | ||
| self.assertEqual(4, len(j["results"][0]["people"])) | ||
| self.assertTrue("id" in first_person and "name" in first_person and "distinct_ids" in first_person) | ||
| self.assertEqual(4, j["results"][0]["count"]) | ||
|
|
||
| def test_basic_pagination(self): | ||
| self._create_sample_data(20) | ||
| request_data = { | ||
| "insight": INSIGHT_PATHS, | ||
| "filter_test_accounts": "false", | ||
| "date_from": "2021-05-01", | ||
| "date_to": "2021-05-10", | ||
| "limit": 15, | ||
| } | ||
|
|
||
| response = self.client.get("/api/person/path/", data=request_data) | ||
| self.assertEqual(response.status_code, status.HTTP_200_OK) | ||
| j = response.json() | ||
| people = j["results"][0]["people"] | ||
| next = j["next"] | ||
|
|
||
| self.assertEqual(15, len(people)) | ||
| self.assertNotEqual(None, next) | ||
|
|
||
| response = self.client.get(next) | ||
| self.assertEqual(response.status_code, status.HTTP_200_OK) | ||
| j = response.json() | ||
| people = j["results"][0]["people"] | ||
| next = j["next"] | ||
| self.assertEqual(5, len(people)) | ||
| self.assertEqual(None, j["next"]) | ||
|
|
||
| @patch("ee.clickhouse.models.person.delete_person") | ||
| def test_basic_pagination_with_deleted(self, delete_person_patch): | ||
| cache.clear() | ||
| self._create_sample_data(110, delete=True) | ||
| request_data = { | ||
| "insight": INSIGHT_PATHS, | ||
| "filter_test_accounts": "false", | ||
| "date_from": "2021-05-01", | ||
| "date_to": "2021-05-10", | ||
| } | ||
|
|
||
| response = self.client.get("/api/person/path/", data=request_data) | ||
| self.assertEqual(response.status_code, status.HTTP_200_OK) | ||
| j = response.json() | ||
| people = j["results"][0]["people"] | ||
| next = j["next"] | ||
| self.assertEqual(0, len(people)) | ||
| self.assertIsNone(next) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters