feat(flags): Enable caching for resilient responses #13708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilkakkar
commented
Jan 13, 2023
neilkakkar
commented
Jan 16, 2023
9 tasks
neilkakkar
commented
Jan 18, 2023
| @@ -15,4 +16,5 @@ | |||
| "Role", | |||
| "RoleMembership", | |||
| "EnterprisePropertyDefinition", | |||
| "FeatureFlagRoleAccess", | |||
There was a problem hiding this comment.
@liyiy this is the reason when running tests locally you'd get the ee_ffroleaccess table doesn't exist, even when it existed in the test db. Wasn't registered in django
|
@EDsCODE lmk if you have any pending comments, will merge this now so I can babysit in Cloud. |
neilkakkar
added a commit
that referenced
this pull request
Jan 18, 2023
This reverts commit 0a1831b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Part of #13601
In this PR:
Introduce caching of team and feature flags. This allows for zero downtime on decide when postgres goes down.
What's in a follow up:
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
Lots of unit tests.
Also, run locally, check decide, make database go down, see decide still works.