Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hogql): nested macros #15126

Merged
merged 4 commits into from
Apr 18, 2023
Merged

fix(hogql): nested macros #15126

merged 4 commits into from
Apr 18, 2023

Conversation

mariusandra
Copy link
Collaborator

Problem

Selecting deeply with WITH macros didn't work.

Changes

Fixes it by adding the missing visit.

How did you test this code?

Added a test

@mariusandra mariusandra requested a review from a team April 18, 2023 09:02
@mariusandra mariusandra requested a review from Twixes April 18, 2023 13:55
@Twixes
Copy link
Collaborator

Twixes commented Apr 18, 2023

Some tests are unhappy

@mariusandra
Copy link
Collaborator Author

The failing tests are

posthog/api/test/test_user.py::TestEmailVerificationAPI
posthog/api/test/test_authentication.py::TestPasswordResetAPI

with

>               self.assertEqual(response.status_code, status.HTTP_429_TOO_MANY_REQUESTS)
E               AssertionError: 204 != 429

I hope these are flakes... 🧐

This was referenced Apr 18, 2023
Open
Merged
@mariusandra mariusandra merged commit 6b0b0f7 into master Apr 18, 2023
@mariusandra mariusandra deleted the hogql-fix-macros branch April 18, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Awaiting requested review from Twixes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariusandra @Twixes