feat(hogql): type class refactor, field to constant type resolving #15129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yakkomajuri
reviewed
Apr 18, 2023
|
|
||
| # https://github.com/ClickHouse/ClickHouse/issues/23194 - "Describe how identifiers in SELECT queries are resolved" | ||
|
|
||
|
|
||
| def resolve_refs(node: ast.Expr, database: Database, scope: Optional[ast.SelectQueryRef] = None): | ||
| def resolve_constant_data_type(constant: Any) -> ConstantType: |
There was a problem hiding this comment.
are NULL constants a thing?
There was a problem hiding this comment.
There are still some decisions to take here... and I'd love to have someone with whom to talk this through.
My understanding so far:
nullis a value that fits everywhere, and not a special data type- you can have a field with with the value
null, but its type would still be "uint8" or "float64" or "bool" or whatever, but with a "nullable" modifier - I needed an "unknown" type, which is now also the default given to any "autodetected" constant type
- this type system still needs a lot of work and some unification across the board (the work touches clickhouse types, but properties are identified as "number" and need to be split to "int" and "float"... and "decimal"?) - so more PRs to come...
yakkomajuri
approved these changes
Apr 18, 2023
Twixes
force-pushed
the
hogql-types-improved
branch
from
2841a55
to
0136a50
Compare
Twixes
approved these changes
Apr 18, 2023
This was referenced Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
UUIDTypeorIntegerTypeorArrayTypefor all supported datatypes.TableOrSelectTypeand refactor some moreCallTypeOut of scope: correct type arguments and return types for functions. Lots more incoming.
How did you test this code?