Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hogql): remove feature flag #15936

Merged
merged 35 commits into from
Jun 29, 2023
Merged

feat(hogql): remove feature flag #15936

merged 35 commits into from
Jun 29, 2023

Conversation

mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Jun 7, 2023

Problem

HogQL is released, but the feature flag is still there.

Changes

  • Removes the flag, and updates all tests, etc to match
  • Remove the old events table
  • Many new snapshots because of the "SQL" tab and changed sidebar

Out of scope

  • Remove the persons list component - splitting this PR into two: refactor(early-access): use query node #16301
  • Does not re-enable "turbo mode" on the events page. It'll still reload every time it's opened. I added the point "switching between pages in the sidebar shouldn't reload the event explorer you had previously opened" to the big list of checkboxes.

How did you test this code?

Clicked around. Fixed all that CI reported.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

28 snapshot changes in total. 0 added, 28 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

25 snapshot changes in total. 0 added, 25 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 25 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

26 snapshot changes in total. 0 added, 26 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

26 snapshot changes in total. 0 added, 26 modified, 0 deleted:

  • chromium: 0 added, 26 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@mariusandra mariusandra marked this pull request as ready for review June 29, 2023 09:21
Copy link
Contributor

@thmsobrmlr thmsobrmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One failing test for web performance, otherwise looks good.

@thmsobrmlr thmsobrmlr self-requested a review June 29, 2023 12:46
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

28 snapshot changes in total. 0 added, 28 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@mariusandra mariusandra enabled auto-merge (squash) June 29, 2023 13:00
@mariusandra mariusandra merged commit 7355359 into master Jun 29, 2023
@mariusandra mariusandra deleted the remove-hogql-feature-flag branch June 29, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants