Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hogql): Add funnels to paths insight #21133

Merged
merged 25 commits into from
Apr 3, 2024

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Mar 25, 2024

Problem

This PR builds upon #21044 to add funnels to paths insights.

Changes

Changes:

  • Uses a funnelPathsFilter as schema key to hold all relevant params. Removes other params from the query schema and adapts filterToQuery functions to accomodate this.
  • Uses a toTimeZone(timestamp, 'UTC') to fix issues with adding an interval and DST transitions.

How did you test this code?

Verified the funnel path can be added and removed locally.

Copy link
Contributor

github-actions bot commented Mar 27, 2024

Size Change: 0 B

Total Size: 824 kB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 824 kB

compressed-size-action

@thmsobrmlr thmsobrmlr changed the title Feature/paths funnels followups feat(hogql): add funnels to paths insight Mar 28, 2024
@thmsobrmlr thmsobrmlr marked this pull request as ready for review March 28, 2024 08:32
@thmsobrmlr thmsobrmlr changed the base branch from feature/paths-funnels to master March 28, 2024 08:33
@thmsobrmlr thmsobrmlr requested a review from a team March 28, 2024 08:34
# Conflicts:
#	posthog/hogql_queries/legacy_compatibility/filter_to_query.py
Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't review very deeply, but looks good overall

Copy link
Contributor

@webjunkie webjunkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it doesn't work anymore to go to the paths from funnels, e.g. by clicking "Show user paths after step". I suspect the URL with the filter is not converted correctly anymore. We can also discuss in standup what the status is here.

@webjunkie webjunkie changed the title feat(hogql): add funnels to paths insight feat(hogql): Add funnels to paths insight Apr 3, 2024
Copy link
Contributor

@webjunkie webjunkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to fix the issues and would merge this. Then we can check #20057 for tests and possibly fix leftover issues.

@thmsobrmlr
Copy link
Contributor Author

I was able to fix the issues and would merge this. Then we can check #20057 for tests and possibly fix leftover issues.

Awesome, go for it!

@webjunkie webjunkie enabled auto-merge (squash) April 3, 2024 14:09
@webjunkie webjunkie merged commit b169fc1 into master Apr 3, 2024
83 checks passed
@webjunkie webjunkie deleted the feature/paths-funnels-followups branch April 3, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants