-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hogql): Add funnels to paths insight #21133
Conversation
Size Change: 0 B Total Size: 824 kB ℹ️ View Unchanged
|
# Conflicts: # posthog/hogql_queries/legacy_compatibility/filter_to_query.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't review very deeply, but looks good overall
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me it doesn't work anymore to go to the paths from funnels, e.g. by clicking "Show user paths after step". I suspect the URL with the filter is not converted correctly anymore. We can also discuss in standup what the status is here.
# Conflicts: # posthog/schema.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to fix the issues and would merge this. Then we can check #20057 for tests and possibly fix leftover issues.
Awesome, go for it! |
Problem
This PR builds upon #21044 to add funnels to paths insights.
Changes
Changes:
funnelPathsFilter
as schema key to hold all relevant params. Removes other params from the query schema and adaptsfilterToQuery
functions to accomodate this.toTimeZone(timestamp, 'UTC')
to fix issues with adding an interval and DST transitions.How did you test this code?
Verified the funnel path can be added and removed locally.