feat(experiments): secondary metrics table #21164
Conversation
|
Size Change: 0 B Total Size: 824 kB ℹ️ View Unchanged
|
|
Needs more work.. |
| > | ||
| {isModalReadOnly ? ( | ||
| <div> | ||
| <ExperimentInsightCreator insightProps={insightProps} /> |
There was a problem hiding this comment.
Here we need -> https://github.com/PostHog/posthog/blob/secondary-metrics-table/frontend/src/scenes/experiments/ExperimentResult.tsx#L215 the valid metric. Potentially worth refactoring ExperimentResults component that you're using for the primary metric to make it work here
| openModalToEditSecondaryMetric: ( | ||
| metric: SecondaryExperimentMetric, | ||
| metricIdx: number, | ||
| readOnly: boolean = false |
There was a problem hiding this comment.
Instead of readOnly I think better to have a showResults param, because its not read only version of the metric selector, but a completely different insight - to avoid confusion
| @@ -17,3 +17,21 @@ export const transformResultFilters = (filters: Partial<FilterType>): Partial<Fi | |||
| display: ChartDisplayType.ActionsLineGraphCumulative, | |||
| }), | |||
| }) | |||
|
|
|||
| export function findKeyWithHighestNumber(obj: Record<string, number> | null): string | null { | |||
There was a problem hiding this comment.
Would be nice to consolidate all highest probability calculations into one
| > | ||
| {showResults && targetResults ? ( | ||
| <div> | ||
| <Query |
There was a problem hiding this comment.
consider extracting this into its own component in a follow up
Changes
Notes:
How did you test this code?
👀