Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(trends): more hogql features #21176

Merged
merged 13 commits into from
Mar 27, 2024
Merged

fix(trends): more hogql features #21176

merged 13 commits into from
Mar 27, 2024

Conversation

mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Mar 26, 2024 •
edited
Loading

Problem

Features removed from #21159 to make that easier to merge

Changes

  • Fixes a bug where you couldn't click "edit sql" and actually run the query on a trend insight with multiple series.
  • Fixes the sorting for some cumulative insights.

How did you test this code?

  • Snapshot tests

@mariusandra mariusandra marked this pull request as ready for review March 26, 2024 22:36
@mariusandra mariusandra requested review from Twixes and a team March 26, 2024 22:37
thmsobrmlr
thmsobrmlr approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@thmsobrmlr thmsobrmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from trends-breakdown-empty-null to master March 27, 2024 10:47
@mariusandra mariusandra enabled auto-merge (squash) March 27, 2024 13:15
@mariusandra mariusandra merged commit 17dd12e into master Mar 27, 2024
129 checks passed
@mariusandra mariusandra deleted the trends-thingies branch March 27, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thmsobrmlr thmsobrmlr thmsobrmlr approved these changes

@Twixes Twixes Awaiting requested review from Twixes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariusandra @thmsobrmlr