Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(3000): interface triangulator #21194

Merged
merged 3 commits into from
Mar 28, 2024
Merged

fix(3000): interface triangulator #21194

merged 3 commits into from
Mar 28, 2024

Conversation

mariusandra
Copy link
Collaborator

Problem

Days are passing us by, soon we're in the next month.

Changes

If you create a multivariate feature flag theme, and set it to a variant with the key bleachedTom, you will evaluate the life choices that led you here, and smile.

Does this work well for both Cloud and self-hosted?

Yes, it really does.

How did you test this code?

👀

Copy link
Contributor

github-actions bot commented Mar 27, 2024

Size Change: +14 B (0%)

Total Size: 824 kB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 824 kB +14 B (0%)

compressed-size-action

dark: false,
sidebarStyle: {
background:
'linear-gradient(rgba(255,255,255,0.7),rgba(255,255,255,0.7)),url(https://www.shutterstock.com/image-photo/soft-wave-blue-ocean-on-600nw-396969259.jpg)',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we allowed to use this photo? let's host it somewhere so it's not a shutterstock URL

},
mainStyle: {
background:
'linear-gradient(rgba(255,255,255,0.7),rgba(255,255,255,0.7)),url(https://pbs.twimg.com/profile_images/1237550450/mstom_400x400.jpg)',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same with this one

Copy link
Member

@raquelmsmith raquelmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually approve it this time

@mariusandra mariusandra merged commit df98bd9 into master Mar 28, 2024
136 checks passed
@mariusandra mariusandra deleted the verticular-triangulator branch March 28, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants