test(plugin-server): Improve the robustness of overflow handling tests #21315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkaemming
commented
Apr 3, 2024
Comment on lines
-100
to
-101
| timestamp: captureEndpointEvent1['timestamp'], | ||
| offset: captureEndpointEvent1['offset'], |
There was a problem hiding this comment.
These were undefined so they weren't being considered in this assertion.
timestamp can be provided to produce, if we want to preserve it across rerouting.
tkaemming
commented
Apr 3, 2024
| @@ -109,23 +114,23 @@ describe('eachBatchParallelIngestion with overflow reroute', () => { | |||
|
|
|||
| it('reroutes excess events to OVERFLOW topic', async () => { | |||
There was a problem hiding this comment.
Can't quite test this by cherry-picking the problematic change (because it also changed these tests), but #20945 (comment) would have caused this test to hang indefinitely now that it actually produces. This would have let us know something weird was going on earlier.
bretthoerner
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#20945 (comment) seems like it should have been caught by tests but wasn't.
Changes
Does this work well for both Cloud and self-hosted?
N/A
How did you test this code?
(This one is hopefully obvious.)