feat: move tracking of important events #25152

raquelmsmith · 2024-09-23T22:40:22Z

Problem

Our product intelligence sometimes gets blocked. It will be more reliable on the server.

Move the following to the server (or make sure they are there):

Start using
- onboarding product selected
Product analytics
- dashboard created
- insight created / saved
- first team event ingested
Platform
- invited team member
Surveys
- survey launched
Feature flags
- feature flag created (already backend)
Session replay
- recording analyzed
- list filter changed

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

github-actions · 2024-09-23T22:50:52Z

Size Change: -842 B (-0.01%)

Total Size: 9.21 MB

ℹ️ View Unchanged

Filename	Size	Change
`frontend/dist/toolbar.js`	9.21 MB	-842 B (-0.01%)

_{compressed-size-action}

posthog-bot · 2024-09-23T22:57:49Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

…ostHog/posthog into chore/move-tracking-to-backend

posthog-bot · 2024-09-24T23:23:51Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-10-01T04:35:13Z

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

chromium: 0 added, 4 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

…ostHog/posthog into chore/move-tracking-to-backend

posthog-bot · 2024-10-01T17:51:52Z

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

chromium: 0 added, 4 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

…ostHog/posthog into chore/move-tracking-to-backend

posthog-bot · 2024-10-01T19:05:44Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

zlwaterfield

Nice work, I know this was a lot of work. Added a few questions but overall looks good.

zlwaterfield · 2024-10-01T19:20:46Z

posthog/session_recordings/session_recording_api.py

+
+        if "viewed" in serializer.validated_data and not request.user.is_anonymous:
+            recording.check_viewed_for_user(user, save_viewed=True)
+            # TODO: make sure this has all the props we want


Should this todo stay?

zlwaterfield · 2024-10-01T19:21:01Z

posthog/api/survey.py

+            "start_date": instance.start_date,
+            "end_date": instance.end_date,
+        }
+        if before_update.start_date is None and instance.start_date is not None:


Clever way of doing this

zlwaterfield · 2024-10-01T19:24:26Z

posthog/api/insight.py

@@ -344,6 +356,8 @@ def create(self, validated_data: dict, *args: Any, **kwargs: Any) -> Insight:
        request = self.context["request"]
        tags = validated_data.pop("tags", None)  # tags are created separately as global tag relationships
        team_id = self.context["team_id"]
+        current_url = request.headers.get("Referer")


Are we sure this Referer property is the way to get the current URL? Will proxies / other things affect this?

I'm not sure. I don't think proxies will matter much because we don't proxy our API urls. If you have a better suggestion then I'm all ears. I'll also ask in dev.

posthog-bot · 2024-10-01T19:25:59Z

📸 UI snapshots have been updated

5 snapshot changes in total. 0 added, 5 modified, 0 deleted:

chromium: 0 added, 5 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-10-01T19:45:50Z

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

chromium: 0 added, 3 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

…ostHog/posthog into chore/move-tracking-to-backend

dmarticus

everything looks fine in the feature success domain!

sentry-io · 2024-10-03T12:32:40Z

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️ CHQueryErrorNetworkError: DB::NetException. DB::NetException: SSL connection unexpectedly closed, while reading from socket... /api/projects/{parent_lookup_team_id}/session_r... View Issue
‼️ NetworkError: Connection refused (ch-online.posthog.net:9440) /api/projects/{parent_lookup_team_id}/session_r... View Issue
‼️ CHQueryErrorQueryWasCancelled: DB::Exception: Received from ch20.posthog.net:9000. DB::Exception: Query was cancelled. Stack trace: /api/projects/{parent_lookup_team_id}/session_r... View Issue
‼️ **CHQueryErrorAllConnectionTriesFailed: DB::NetException. DB::NetException: All connection tries failed. Log: ** /api/projects/{parent_lookup_team_id}/session_r... View Issue

_{Did you find this useful? React with a 👍 or 👎}

raquelmsmith added 3 commits September 23, 2024 09:43

remove event that's no longer used

75da3e8

capture insight activities (create, update) from backend

8956fee

move invite events to backend

2b676cb

github-actions bot added 2 commits September 23, 2024 22:53

Update query snapshots

fc3aae8

Update UI snapshots for chromium (2)

e23975f

raquelmsmith and others added 6 commits September 24, 2024 11:03

change how insights are being tracked a bit

9175397

add url and session to dashboard created

49eed33

move to server

09ec2d0

Merge branch 'chore/move-tracking-to-backend' of https://github.com/P…

c92f126

…ostHog/posthog into chore/move-tracking-to-backend

fix some typing issues

09a488a

Update UI snapshots for chromium (2)

29da167

github-actions bot and others added 5 commits September 24, 2024 23:40

Update query snapshots

5030231

Merge branch 'master' into chore/move-tracking-to-backend

5c847a3

move recording viewed and analyzed to server

982506c

Update UI snapshots for chromium (1)

12f98c6

Update UI snapshots for chromium (2)

b2da048

raquelmsmith and others added 5 commits October 1, 2024 10:31

mark viewed on recording end

d77fb3d

Merge branch 'chore/move-tracking-to-backend' of https://github.com/P…

9b804ae

…ostHog/posthog into chore/move-tracking-to-backend

fix types

15f686c

Update UI snapshots for chromium (1)

6993527

Update UI snapshots for chromium (2)

c849e2b

raquelmsmith added 4 commits October 1, 2024 11:01

fix some other tests

3b70d7c

fail validation if no recording

2b2e1b6

Merge branch 'chore/move-tracking-to-backend' of https://github.com/P…

dd94e38

…ostHog/posthog into chore/move-tracking-to-backend

Merge branch 'master' into chore/move-tracking-to-backend

ea5ab7c

github-actions bot and others added 4 commits October 1, 2024 18:42

Update query snapshots

b8934d0

move surveys events

0f02b2a

Merge branch 'chore/move-tracking-to-backend' of https://github.com/P…

746376f

…ostHog/posthog into chore/move-tracking-to-backend

Update UI snapshots for chromium (1)

2324f12

raquelmsmith marked this pull request as ready for review October 1, 2024 19:07

raquelmsmith requested review from pauldambra, a team and dmarticus October 1, 2024 19:08

Update UI snapshots for chromium (1)

f6e1ebd

zlwaterfield approved these changes Oct 1, 2024

View reviewed changes

Update UI snapshots for chromium (2)

2fa75e5

Update UI snapshots for chromium (2)

66679e7

raquelmsmith added 5 commits October 1, 2024 14:21

fix types

9b882e7

schema.json

d607e26

Merge branch 'chore/move-tracking-to-backend' of https://github.com/P…

ed8ddfa

…ostHog/posthog into chore/move-tracking-to-backend

update schema.py

b2b984a

maybe fix replay tests?:

7715d5c

aspicer approved these changes Oct 2, 2024

View reviewed changes

dmarticus approved these changes Oct 2, 2024

View reviewed changes

raquelmsmith requested review from Phanatic and dmarticus October 2, 2024 15:08

raquelmsmith merged commit ddede4d into master Oct 2, 2024
93 checks passed

raquelmsmith deleted the chore/move-tracking-to-backend branch October 2, 2024 21:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: move tracking of important events #25152

feat: move tracking of important events #25152

raquelmsmith commented Sep 23, 2024 •

edited

Loading

github-actions bot commented Sep 23, 2024 •

edited

Loading

posthog-bot commented Sep 23, 2024

posthog-bot commented Sep 24, 2024

posthog-bot commented Oct 1, 2024

posthog-bot commented Oct 1, 2024

posthog-bot commented Oct 1, 2024

zlwaterfield left a comment

zlwaterfield Oct 1, 2024

zlwaterfield Oct 1, 2024

zlwaterfield Oct 1, 2024

raquelmsmith Oct 1, 2024

posthog-bot commented Oct 1, 2024

posthog-bot commented Oct 1, 2024

dmarticus left a comment

sentry-io bot commented Oct 3, 2024 •

edited

Loading

feat: move tracking of important events #25152

feat: move tracking of important events #25152

Conversation

raquelmsmith commented Sep 23, 2024 • edited Loading

Problem

Changes

Does this work well for both Cloud and self-hosted?

How did you test this code?

github-actions bot commented Sep 23, 2024 • edited Loading

posthog-bot commented Sep 23, 2024

📸 UI snapshots have been updated

posthog-bot commented Sep 24, 2024

📸 UI snapshots have been updated

posthog-bot commented Oct 1, 2024

📸 UI snapshots have been updated

posthog-bot commented Oct 1, 2024

📸 UI snapshots have been updated

posthog-bot commented Oct 1, 2024

📸 UI snapshots have been updated

zlwaterfield left a comment

Choose a reason for hiding this comment

zlwaterfield Oct 1, 2024

Choose a reason for hiding this comment

zlwaterfield Oct 1, 2024

Choose a reason for hiding this comment

zlwaterfield Oct 1, 2024

Choose a reason for hiding this comment

raquelmsmith Oct 1, 2024

Choose a reason for hiding this comment

posthog-bot commented Oct 1, 2024

📸 UI snapshots have been updated

posthog-bot commented Oct 1, 2024

📸 UI snapshots have been updated

dmarticus left a comment

Choose a reason for hiding this comment

sentry-io bot commented Oct 3, 2024 • edited Loading

Suspect Issues

raquelmsmith commented Sep 23, 2024 •

edited

Loading

github-actions bot commented Sep 23, 2024 •

edited

Loading

sentry-io bot commented Oct 3, 2024 •

edited

Loading