feat: Add milliseconds and fractional second support to humanFriendlyDuration #25313
+58
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbie-c
changed the base branch from
master
to
feature/add-web-vitals-to-overview
robbie-c
changed the title
|
Size Change: 0 B Total Size: 9.21 MB ℹ️ View Unchanged
|
robbie-c
force-pushed
the
feature/add-web-vitals-to-overview
branch
from
89b50af
to
339c279
Compare
robbie-c
force-pushed
the
feature/add-ms-to-human-friendly-duration
branch
from
845fc8d
to
74552c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I need to merge the other PR first and rebase thisProblem
I wanted to be able to show 1.5s or 300ms for the LCP scores. This shouldn't change existing behaviour
Changes
If seconds are <60, optionally show decimal places with either fixed or precision
If seconds are <1, show the rounded number of ms
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Added some tests :)